Display up to 4 channels and export to CSV #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcdawes
reviewed
Jun 21, 2017
| @@ -96,7 +96,7 @@ def get_xdata(self): | |||
| self.write("HORIZONTAL:RECORDLENGTH?") | |||
| time_size = int(self.read(30)) | |||
|
|
|||
| time = numpy.arange(0,timescale*10,timescale*10/time_size) | |||
| time = numpy.arange(0,timescale*10,timescale*10/time_size*2) # For some reason the output was too short compared to the data buffer | |||
There was a problem hiding this comment.
This may be scope-dependent, I'll look into it, but am merging for now. There is a better way to get the record length directly from the scope and that is how it should be done in an instrument-neutral way.
amcdawes
reviewed
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few modifications as follows:
I would be happy to make revisions of the code and updates if needed. Note that this PR addresses issues . #1 and #2. Let me know if I can do anything to improve it!