Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTSP Proton CtMod #470

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add RTSP Proton CtMod #470

merged 2 commits into from
Nov 25, 2024

Conversation

DavidoTek
Copy link
Owner

@DavidoTek DavidoTek commented Oct 23, 2024

Fix #412

Yeah, this was very straightforward to add. I made a branch here (forgot to put it under Advanced Mode): https://github.com/sonic2kk/ProtonUp-Qt/tree/rtsp-ge-proton (my fork is only for the purposes of contributing here, and as a playground, it's not a replacement for ProtonUp-Qt, purely a development fork)
I verified that it showed up, downloaded, and extracted correctly. The extracted contents have the same structure as GE-Proton, it uses tagging properly, uses the same archive format, so it was straightforward.
As a disclaimer: I am not sure if we want to go this direction though, so I won't open a PR yet. That branch is only there to serve as a proof-of-concept that it is possible, not a confirmation or endorsement :-)

@DavidoTek
Copy link
Owner Author

Should this be hidden behind advmode?

@sonic2kk
Copy link
Contributor

I guess in this case, whether or not it goes behind Advanced Mode is more a question of "clutter" in the dropdown.

In terms of codebase "precedent", we put NorthStar Proton behind Advanced Mode, so I suppose we can do it here, too. Makes sense to me :-)

We do this for NorthStar Proton, probably makes sense
Helps declutter the dropdown too.
@sonic2kk
Copy link
Contributor

Went ahead and pushed that change and rebased as well. Tested and it seems to work. Didn't launch any games with it but ProtonUp-Qt was able to download and extract the archive, and it looks correct and matches a standard Proton compatibility tool file structure.

image


As an aside, I've mentioned a GE-Proton ctmod refactor that I've been working on in the past. This change wouldn't get in the way of that, we would be able to continue using this ctmod in the same way (since the goal would be having a GE-Proton ctmod as a base class, exactly as we do here). Just wanted to call this out :-)

@DavidoTek DavidoTek merged commit 685bdad into DavidoTek:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for RTSP GE Proton
2 participants