Swift 4.2 #10
Open
Swift 4.2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coeur
reviewed
Sep 10, 2018
| @@ -34,11 +34,11 @@ open class MarkdownHeader: MarkdownLevelElement { | |||
| attributedString.deleteCharacters(in: range) | |||
| } | |||
|
|
|||
| open func attributesForLevel(_ level: Int) -> [NSAttributedStringKey: Any] { | |||
| open func attributesForLevel(_ level: Int) -> [NSAttributedString.Key: Any] { | |||
There was a problem hiding this comment.
This alone will break compatibility with Swift 4.1: better also declare a compatibility layer with previous Swift version.
There was a problem hiding this comment.
Maybe create a typealias like this.
#if swift(>=4.2)
public typealias MarkdownAttribute = [NSAttributedString.Key: Any]
#else
public typealias MarkdownAttribute = [NSAttributedStringKey: Any]
#endif
Coeur
reviewed
Sep 10, 2018
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
This is good, but can be done in an independant pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Swift 4.2 Support