Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better font for matplotlib #780

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Dec 9, 2024

This pull request includes changes to the write method in the pymchelper/writers/plots.py file to improve error handling and formatting. The most important changes include updating the string formatting method, enhancing logging, and adding error handling for plot saving.

Enhancements to string formatting and logging:

  • Changed the string formatting for output_filename to use f-strings for better readability.
  • Updated the logging statement to use a more efficient logging method.

Improved error handling:

  • Added a try-except block to handle ValueError when saving plots, including logging the error and attempting to save the plot with a different font configuration.

@grzanka grzanka linked an issue Dec 9, 2024 that may be closed by this pull request
@grzanka grzanka self-assigned this Dec 9, 2024
@grzanka grzanka merged commit d928e56 into master Dec 9, 2024
14 checks passed
@grzanka grzanka deleted the 575-fix-single-executable-image-converter branch December 9, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant