Fix TOPAS reader #687
Open
Fix TOPAS reader #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen that the TOPAS output contains result only for Sum + StandardDeviation, instead of Mean+StandardDeviation. Current version of TOPAS reader assumes that the only output suitable for reading is with Mean and StdDev. Then Mean is assigned to data_raw and StdDev to data_error. That means that many useful output files won't be digested.
Here I propose a different approach - each of the results will end up in a separate page in the estimator. There will be one page for Mean (data_raw == mean) and one page for standard deviation (data_raw == stddev)