-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
626 idea generate mc summary table #634
Open
nbassler
wants to merge
3
commits into
master
Choose a base branch
from
626-idea-generate-mc-summary-table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import logging | ||
import time | ||
import urllib.parse | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class MCSumWriter: | ||
def __init__(self, filename, options): | ||
logger.debug("Initialising Inspector writer") | ||
self.options = options | ||
|
||
def write(self, estimator): | ||
"""Print all keys and values from estimator structure | ||
|
||
they include also a metadata read from binary output file | ||
""" | ||
|
||
s = estimator.total_run_time | ||
if s < 60: | ||
ts = time.strftime('%S seconds', time.gmtime(s)) | ||
elif s < 3600: | ||
ts = time.strftime('%M minutes', time.gmtime(s)) | ||
else: | ||
ts = time.strftime('%H hours %M minutes', time.gmtime(s)) | ||
|
||
print('Item name | Description | References') | ||
print('|---|---|---|') | ||
print(f'| Code Version | {estimator.mc_code_version} | |') | ||
print('| Validation | |') | ||
print(f'| Timing | {estimator.file_counter} jobs, {ts} total runtime |') | ||
print('| Geometry | |') | ||
print('| Source | |') | ||
print('| Physics | |') | ||
print('| Scoring | |') | ||
print(f'|\\# histories | {estimator.total_number_of_primaries} | |') | ||
|
||
url = urllib.parse.quote("https://doi.org/10.1002/mp.12702", safe="") | ||
url = "https://doi.org/10.1002/mp.12702" | ||
print('Table caption: Summary of Monte Carlo simulations parameters in AAPM TG268 format.') | ||
print(f'[See Sechopoulos et al. (2018), {url}.]') | ||
return 0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a new writer for that functionality ?
Could it be part of
inspect
command ?Like:
convertmc inspect blabla.bdo --summary
or
convertmc inspect --many "*.bdo" --summary
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of additional options for what format you would like to have. Also it may collide with inspect -d option, and may get more complex if also the scoring field will be filled out.
Other questions: we could hardcode also SH references, for convenience and make reference list at bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pymchelper
also can read Fluka binary files, so SH12A references would need to be saved in a smarter way.