-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status script generation #175
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 59.15% 61.01% +1.85%
==========================================
Files 13 13
Lines 923 967 +44
Branches 150 150
==========================================
+ Hits 546 590 +44
Misses 315 315
Partials 62 62
Continue to review full report at Codecov.
|
mcpartools/scheduler/data/status.sh
Outdated
|
||
if [[ $CMD_STATUS -eq 0 && $SAVE_TO_FILE_FLAG = true ]] | ||
then | ||
echo "Status successfully saved to file." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you print on the screen to which file the status was saved ?
cat $ERR >> "$LOGFILE" | ||
fi | ||
|
||
MERGE_LOGS_CMD="sbatch --dependency=afterany:$LAST_JOB_ID --output='{log_dir:s}/output_%j_merge_logs.log' --error='{log_dir:s}/error_%j_merge_logs.log' --parsable {main_dir:s}/workspace/merge_logs.sh -s > $OUT 2> $ERR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see much sense in submitting log merging as separate job. It should either be simply executed by user in the same session as status.sh
script is being called or added at the end of collect script.
I suspect that:
- in 99% cases user would simply call
status.sh
without-s
option and will never take look on the logs, while merge logs will always be called, adding unnecessary jobs to the queue. - execution time is so short of "merge logs" that it probably will execute faster than the time needed to enter running state
#87