-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment Definition Changes #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have three suggestions for changing the regex, mainly disallowing whitespace for simplicity and some consistency for naming and using delimiters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex requires a comment that really explains what it does
Maybe we could also use constants for the delimiters ( |
Then you'll have to build the Regex from that EDIT: |
Agreed. I added documentation |
You still allow | pipes in labels... |
Fixed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are issues with your term validation |
The same issue existed beforehand. I just adjusted the Editor to the new logic there |
At least the ! Issue. I'll take care of the label issue |
Done @uuqjz |
|
@uuqjz I fixed that but Validation and Suggestions need to be touched by our new WebDev anyway. This code is hotglued together to work |
@Nicolas-Boltz please rereview. Its fine (for now) from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@01Parzival10 I leave it up to you to merge this.
Instead of using the WebEditor specific behavior definition, assignments are now defined like they are in the DFD-MetaModel.
Former set-Actions now work like this:
Assignment({input_Pins};Term;{out_Label}) e.g. Assignment({data, request};Sensitivity.Personal || TRUE;{Sensitivity.Public})
forwarding now like this:
Forwarding({input_pins})
e.g. Forwading({data|request, encrypt}) [with data|request being the pin where both data and request arrive]
Auto-Completion and validation have been adjusted