Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to exclude function from Datadog #86

Closed
wants to merge 2 commits into from

Conversation

nholbrook
Copy link
Contributor

What does this PR do?

This PR adds a config option that allows users to specify functions to be excluded from Datadog.

Motivation

Currently, there is no way to prevent Datadog from updating certain functions. One example of a scenario where this is a problem is when using this plugin with serverless-plugin-warmup. Datadog will update the handler of the warmer function created by this plugin, which prevents it from working.

Testing Guidelines

I added an additional test case and updated all associated test cases.

Additional Notes

This issue is documented here.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@nholbrook nholbrook requested a review from a team as a code owner December 5, 2020 18:39
@DarcyRaynerDD
Copy link
Collaborator

Hey @nholbrook thanks for the PR. This is looking good, and I think we will accept the feature for the next release, but for some reason the github actions to verify the branch weren't triggered. I'm going to pull this branch into the repo, and recreate the PR.

@nholbrook
Copy link
Contributor Author

Closing because @DarcyRaynerDD recreated this PR (#87) due to issue with GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants