AMLII-1359: Adds a local docker-compose env to test JMXFetch inside the agent #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosroman
reviewed
Dec 28, 2023
docker-compose.yaml
Outdated
Comment on lines
22
to
24
| environment: | ||
| - DD_API_KEY=000000001 | ||
| - DD_JMX_TELEMETRY_ENABLED=true |
There was a problem hiding this comment.
Suggested change
| environment: | |
| - DD_API_KEY=000000001 | |
| - DD_JMX_TELEMETRY_ENABLED=true | |
| env_file: .env # has entry with DD_API_KEY=000000001 | |
| environment: | |
| - DD_JMX_TELEMETRY_ENABLED=true |
carlosroman
approved these changes
Dec 28, 2023
Co-authored-by: Kaylyn <[email protected]>
|
@apigirl if your concern is addressed, can I get an approval here please? |
aliciascott
approved these changes
Jan 18, 2024
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) Use |
|
❌ MergeQueue Tests failed on this commit 36fede8 You should fix those tests and then re-add your pull request to the queue! Details
checks are failing:
If you need support, contact us on Slack #ci-interfaces with those details! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
docker-composebased environment where local changes to JMXFetch can be easily tested.No particular setup required, simply running
docker compose upwill build and run the necessary containers.A future improvement would be to allow custom configurations for
misbehaving-jmx-serverso that more than 1 bean can be tested, however that is left for future improvement.