Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMLII-1358 - Adding support for Generational ZGC #502

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

carlosroman
Copy link
Contributor

@carlosroman carlosroman commented Dec 27, 2023

Starting with JDK 21, multi-generation support has been added to ZGC (see here).

This PR adds a new mappings to the new GC default JMX metrics and creates the following metrics:

  • two jvm.gc.zgc_cycles_collection_count - each with different name tags (ZGC Major Cycles and ZGC Minor Cycles)
  • two jvm.gc.zgc_cycles_collection_time - each with different name tags (ZGC Major Cycles and ZGC Minor Cycles)
  • two jvm.gc.zgc_pauses_collection_count - each with different name tags (ZGC Major Pauses and ZGC Pauses Cycles)
  • two jvm.gc.zgc_pauses_collection_time - each with different name tags (ZGC Pauses Cycles and ZGC Pauses Cycles)

Example:
image

@carlosroman carlosroman requested a review from a team as a code owner December 27, 2023 18:11
@carlosroman carlosroman force-pushed the carlosroman/adding-gc-UseZGC_ZGenerational branch from c398012 to cb484e0 Compare December 28, 2023 10:29
@carlosroman carlosroman requested a review from a team as a code owner December 28, 2023 10:29
@carlosroman carlosroman changed the title Adding support for Generalional ZGC Adding support for Generational ZGC Dec 28, 2023
@carlosroman carlosroman force-pushed the carlosroman/adding-gc-UseZGC_ZGenerational branch from cb484e0 to 538a1f9 Compare December 28, 2023 10:30
@carlosroman carlosroman changed the title Adding support for Generational ZGC AMLII-1358 - Adding support for Generational ZGC Dec 28, 2023
Copy link

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs team review needed

Copy link
Contributor

@scottopell scottopell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Be sure to update our docs as well

@carlosroman carlosroman merged commit f71b32e into master Jan 3, 2024
9 checks passed
@carlosroman carlosroman deleted the carlosroman/adding-gc-UseZGC_ZGenerational branch January 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants