Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMLII-1194 - Updated CI JDKs to use the current LTS versions of the JDK #491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carlosroman
Copy link
Contributor

No description provided.

@carlosroman carlosroman requested a review from a team as a code owner October 25, 2023 10:12
@carlosroman carlosroman force-pushed the carlosroman/ci-tests-for-LTS-JDKs branch from 29b1bbb to 59ce856 Compare October 25, 2023 10:48
- image: cimg/openjdk:15.0
<<: *build_steps

# JDK 11 (LTS) - 30 Sep 2029 (extended support)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this say jdk 17?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍🏽

@@ -17,34 +17,51 @@ jobs:
docker:
- image: cimg/openjdk:8.0
<<: *lint_steps

# JDK 8 (LTS) - 31 Dec 2030 (extended support)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a good reference you have for these LTS dates, may be useful to drop in here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used https://endoflife.date/oracle-jdk to work them out.

test_openjdk17:
docker:
- image: cimg/openjdk:17.0
<<: *build_steps

# Available in Ubuntu 22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this comment mean? Is jdk 18 what ships by default with ubuntu 22.04?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at which ones we test with + which ones are in the LTS version of Ubuntu. Mainly as trying to figure out what the test matrix should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants