Add warning for duplicate instance name #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayz
force-pushed
the
raymond.zhao/AMLII-1111-warn-duplicate-instance-name
branch
from
a8a11de to
99f96b2
Compare
scottopell
reviewed
Oct 11, 2023
scottopell
reviewed
Oct 12, 2023
| @@ -828,6 +830,8 @@ public void init(final boolean forceNewConnection) { | |||
| this.brokenInstanceMap.clear(); | |||
|
|
|||
| final List<Instance> newInstances = new ArrayList<>(); | |||
| // used to track instance names already seen | |||
| Set<String> instanceNames = new HashSet<String>(); | |||
There was a problem hiding this comment.
Suggested change
| Set<String> instanceNames = new HashSet<String>(); | |
| Set<String> instanceNamesSeen = new HashSet<String>(); |
This is a good example of a comment that would be better expressed in the naming of the variable IMO
| final String instanceName = (String) configInstance.get("name"); | ||
| if (instanceName != null) { | ||
| if (instanceNames.contains(instanceName)) { | ||
| log.warn("Instance with name: {} already exists", instanceName); |
There was a problem hiding this comment.
Suggested change
| log.warn("Instance with name: {} already exists", instanceName); | |
| log.warn("Found multiple instances with name: '{}'. Instance names should be unique, update the 'name' field on your instances to be unique.", instanceName); |
My thought here is to have some call-to-action so that someone looking at this warning log will know what needs to happen to address this error.
(and make it the same for the json configs below)
carlosroman
reviewed
Oct 16, 2023
rayz
force-pushed
the
raymond.zhao/AMLII-1111-warn-duplicate-instance-name
branch
from
96eba4f to
fbf9c49
Compare
scottopell
approved these changes
Oct 19, 2023
rayz
force-pushed
the
raymond.zhao/AMLII-1111-warn-duplicate-instance-name
branch
from
fbf9c49 to
5227dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently attempt to instantiate all instances even if an instance with the same name has already been seen.
This pr adds a warn log