Better local docker instructions for misbehaving-jmx-server #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh123man
previously approved these changes
Sep 21, 2023
drichards-87
previously approved these changes
Sep 21, 2023
scottopell
dismissed stale reviews from drichards-87 and gh123man
via
5ad03f1
Co-authored-by: DeForest Richards <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a full docker-compose that includes the Agent as well as the jmx testing server with AD labels.
By running both misbehaving-jmx-server and the agent in the same bridge network (default for docker-compose), we're able to use the docker-compose hostname to connect from the Agent.
Other options for docker development will require a manual second step where the rmi-hostname is set on the misbehaving-jmx-server supervisor.
The above applies to a scenario where both the agent and misbehaving-jmx-server are running in a container. If you are running only the misbehaving-jmx-server in a container and the agent on the host, networking can be a bit tricky, stay tuned for a future PR documenting how to do this.