Update mib_source_url to a Datadog fork of mibs.snmplabs.com #9952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ian28223
changed the title
AlexandreYang
previously approved these changes
Aug 24, 2021
datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/translate_profile.py
Outdated
Show resolved
Hide resolved
ian28223
force-pushed
the
ian.bucad/update_mib_source
branch
from
83e8e69 to
9ae1df0
Compare
gmarabout
previously approved these changes
Sep 8, 2021
https://github.com/projx/snmp-mibs has been disabled
pducolin
force-pushed
the
ian.bucad/update_mib_source
branch
from
9ae1df0 to
8721a7f
Compare
|
Fixed conflict and pushed, thank you for creating a public repo with all the mibs ❤️ ❤️ ❤️ |
pducolin
previously approved these changes
Sep 8, 2021
4 tasks
AlexandreYang
previously approved these changes
Sep 9, 2021
AlexandreYang
dismissed stale reviews from pducolin and themself
via
b8fe7d4
AlexandreYang
approved these changes
Sep 9, 2021
gmarabout
approved these changes
Sep 9, 2021
hithwen
approved these changes
Sep 9, 2021
FlorianVeaux
approved these changes
Sep 9, 2021
coignetp
approved these changes
Sep 9, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
* Update mib_source_url https://github.com/projx/snmp-mibs has been disabled * code review * Fix imports order Co-authored-by: Alexandre Yang <[email protected]> 24b4bcc
ChristineTChen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mib_source_urlto https://github.com/DataDog/mibs.snmplabs.com - which is our own fork of https://github.com/cisco-kusanagi/mibs.snmplabs.comMotivation
http://mibs.thola.io/asn1/also works but is also a fork of cisco-kusanagi/mibs.snmplabs.comAdditional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached