Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes for dogstastd_cardinality #27186

Closed
wants to merge 3 commits into from
Closed

Conversation

JakeYankovich
Copy link
Contributor

What does this PR do? What is the motivation?

This PR adds a couple notes about the pros and cons of the different options for DD_DOGSTATSD_TAG_CARDINALITY
sources:

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@JakeYankovich JakeYankovich requested a review from a team as a code owner January 17, 2025 20:46
@janine-c janine-c self-assigned this Jan 17, 2025
@janine-c
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 17, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-17 21:56:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-17 22:41:07 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@janine-c
Copy link
Contributor

/merge -c

@janine-c
Copy link
Contributor

@JakeYankovich I noticed this wasn't building, and realized it was because your branch name didn't have a slash in it, as per our branch naming convention. I know you wanted to get this out quickly, so I duplicated your change in a different PR (#27191) and am publishing it now. Sorry for the inconvenience!

@janine-c janine-c closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants