-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dev) Add VS instructions for using custom URL #27080
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few small things, but otherwise, looks good.
@@ -83,6 +83,14 @@ When you start editing a source file supported by Static Analysis, the extension | |||
6. Add services, and save your solution. | |||
7. Go to **Extensions > Datadog > Code Insights**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of scope for this PR, but I noticed this step is a repeat of step 5 without explaining what the user is supposed to be able to do or see once they're back on this page. I think it would be worth clarifying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll make a note to look into this.
Co-authored-by: Rosa Trieu <[email protected]>
/merge |
Devflow running:
|
* (dev) Add VS instructions for using custom URL * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Rosa Trieu <[email protected]> * Update content/en/developers/ide_plugins/visual_studio/_index.md --------- Co-authored-by: Rosa Trieu <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes