Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev) Add VS instructions for using custom URL #27080

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

hestonhoffman
Copy link
Contributor

@hestonhoffman hestonhoffman commented Jan 13, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@hestonhoffman hestonhoffman requested a review from a team as a code owner January 13, 2025 17:47
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few small things, but otherwise, looks good.

content/en/developers/ide_plugins/visual_studio/_index.md Outdated Show resolved Hide resolved
content/en/developers/ide_plugins/visual_studio/_index.md Outdated Show resolved Hide resolved
@@ -83,6 +83,14 @@ When you start editing a source file supported by Static Analysis, the extension
6. Add services, and save your solution.
7. Go to **Extensions > Datadog > Code Insights**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of scope for this PR, but I noticed this step is a repeat of step 5 without explaining what the user is supposed to be able to do or see once they're back on this page. I think it would be worth clarifying.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll make a note to look into this.

@hestonhoffman
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 14, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-14 15:55:30 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-14 16:01:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 7aa751b into master Jan 14, 2025
15 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the heston/DOCS-9591 branch January 14, 2025 16:01
domalessi pushed a commit that referenced this pull request Jan 20, 2025
* (dev) Add VS instructions for using custom URL

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Rosa Trieu <[email protected]>

* Update content/en/developers/ide_plugins/visual_studio/_index.md

---------

Co-authored-by: Rosa Trieu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants