-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML-OB] document submit_evaluation_for
API in the Python SDK
#27075
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
submit_evaluation_for
API in the Python SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple thoughts, otherwise looks good to me
@@ -519,45 +519,21 @@ def rag_workflow(user_question): | |||
|
|||
## Evaluations | |||
|
|||
The LLM Observability SDK provides the methods `LLMObs.export_span()` and `LLMObs.submit_evaluation()` to help your traced LLM application submit evaluations to LLM Observability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably wanna keep a reference to the old function and mention that it's deprecated so that if someone tries to go back to our docs to find it they aren't too confused.
Co-authored-by: kyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple style/format suggestions
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Yun Kim <[email protected]>
…cumentation into evan.li/submit-evaluation-for
Created DOCS-9870 for docs review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one small suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted a couple of typos. Just let me know when this is ready for quick approval, thanks!
Co-authored-by: Yun Kim <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
What does this PR do? What is the motivation?
We made an update to the Eval metric API to allow tag-based joining for eval metrics (#27074)
This PR documents the corresponding SDK method that supports tag-based joining
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes