Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hugo-bin version v0.123.0 #23949

Merged
merged 95 commits into from
Jul 15, 2024
Merged

Conversation

StefonSimmons
Copy link
Contributor

@StefonSimmons StefonSimmons commented Jul 1, 2024

What does this PR do? What is the motivation?

bumps hugo-bin

NOTE: PRs to remove kind from external sources (these are non-blocking for this PR):

Merge instructions

  • Please merge after webops reviews

Additional notes

Full site QA needed due to Hugo version bump: https://docs-staging.datadoghq.com/stefon.simmons/bump-hugo-bin-version/

We will re-enable the preview cache flag after QA is completed.

StefonSimmons and others added 30 commits June 18, 2024 16:33
…documentation into stefon.simmons/update-kind-fm-5
bgdeutsch and others added 6 commits July 10, 2024 13:36
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
@bgdeutsch bgdeutsch requested a review from domalessi July 11, 2024 18:52
@bgdeutsch
Copy link
Collaborator

I've noticed a few things:

  • An update with master locally meant i also needed to update en/agent/guide to remove some more kind entries
  • The 404 page has no left nav
  • Some images aren't working e.g see these pages here and here
  • I've also noticed a number of urls now have the anchor in the href or query params in it, this doesn't appear to be causing any issues but thought i should call it out

thanks @davidejones!

  • there may still be some commits containing kind from translations or other changes. that param is mostly gone from source files in transifex, and any working branches in docs containing kind will just have to be updated after this PR goes out.
  • 404 page should be showing the left nav now
  • images should be working again
  • the URLs containing anchor or query params doesnt seem to have any effect as you mentioned.

hestonhoffman
hestonhoffman previously approved these changes Jul 12, 2024
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poked around in preview - LGTM, but I think the cache value needs to be switched back?

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local build is also failing for me on:

Error: error building site: process: readAndProcessContent: "/Users/heston.hoffman/repos/documentation/content/en/code_analysis/static_analysis_rules/csharp-best-practices/avoid-call-gc-suppress-finalize.md:1:1": unknown kind "documentation" in front matter

Weird that it's not happening in CI. I did a clean-all before building.
Does the logic that removes the kind parameter need to be in the pull-and-push-folder action as well?

@hestonhoffman hestonhoffman dismissed their stale review July 12, 2024 20:11

Possible bug

Signed-off-by: Brian Deutsch <[email protected]>
Signed-off-by: Brian Deutsch <[email protected]>
@hestonhoffman hestonhoffman merged commit 5b6d1c6 into master Jul 15, 2024
13 of 14 checks passed
@hestonhoffman hestonhoffman deleted the stefon.simmons/bump-hugo-bin-version branch July 15, 2024 19:14
buraizu added a commit that referenced this pull request Jul 15, 2024
buraizu added a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants