add option to enable network check and document it #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awww I was excited waiting for this in the 5.9.0 release but looks like it didn't make it in :'( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds an option to enable the network check in the docker image. More precisely we used to
rm network.yaml.defaultin the dockerfile, now it's deleted in the entrypoint only if theNETWORK_CHECKenv var is not set. So the default behavior stays the same, but people who know what they're doing can enable it.Why
This allows to monitor the network throughput for the host if the container runs with un-containerized networking (using
--net=host). README.md has been updated to explain clearly the implications and the arrangements to make.Note: using this option without the
--net=hostoption will work but the metrics will be irrelevant. They will only report dd-agent network metrics which are not really useful and are already collected by the docker check anyway.