Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: mandatory issue templates (AIDM-426) #4235

Merged
merged 8 commits into from
Dec 23, 2024

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Dec 17, 2024

What does this PR do?

  • disable freeform issues
  • adds two issue templates
  • adds a security document

Motivation:

  • standardizes the create issue experience across tracers

Additional Notes:

  • see the node.js create issue screen for an example of how this will look
  • I don't know the Ruby ecosystem so feel free to recommend any changes
    • e.g. are ruby gems the main unit of packaging?

Change log entry
None.

@tlhunter tlhunter added docs Involves documentation dev/github Github repository maintenance and automation dev/internal Other internal work that does not need to be included in the changelog labels Dec 17, 2024
@tlhunter tlhunter requested a review from a team as a code owner December 17, 2024 22:52
Copy link

github-actions bot commented Dec 17, 2024

Thank you for updating Change log entry section 👏

Visited at: 2024-12-17 23:46:28 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 17, 2024

Datadog Report

Branch report: tlhunter/create-issue-standard
Commit report: 425da28
Test service: dd-trace-rb

✅ 0 Failed, 22122 Passed, 1475 Skipped, 5m 31.53s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024

Benchmarks

Benchmark execution time: 2024-12-23 21:08:50

Comparing candidate commit 425da28 in PR branch tlhunter/create-issue-standard with baseline commit c116d75 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, suggesting we keep one of the existing sections, but overall super great work!

.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
@tlhunter tlhunter enabled auto-merge (squash) December 18, 2024 15:59
@tlhunter tlhunter force-pushed the tlhunter/create-issue-standard branch from 274d269 to 951c71f Compare December 20, 2024 21:06
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (c116d75) to head (425da28).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4235      +/-   ##
==========================================
- Coverage   97.75%   97.74%   -0.01%     
==========================================
  Files        1355     1355              
  Lines       82366    82365       -1     
  Branches     4230     4230              
==========================================
- Hits        80514    80506       -8     
- Misses       1852     1859       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlhunter tlhunter merged commit 44f36d3 into master Dec 23, 2024
337 checks passed
@tlhunter tlhunter deleted the tlhunter/create-issue-standard branch December 23, 2024 21:09
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 23, 2024
Comment on lines -22 to -23
**How does `datadog` help you?**
<!-- Optionally, tell us why and how you're using datadog, and what your overall experience with it is! -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, would it be reasonable to also re-add the "help you" question to the feature requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/internal Other internal work that does not need to be included in the changelog docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants