-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-3182 DI: remove hard dependency on tracing #4223
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22103 Passed, 1457 Skipped, 5m 28.75s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4223 +/- ##
==========================================
- Coverage 97.75% 97.75% -0.01%
==========================================
Files 1355 1355
Lines 82165 82189 +24
Branches 4207 4213 +6
==========================================
+ Hits 80321 80344 +23
- Misses 1844 1845 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @ivoanjo's point here, but overall awesome work!
What does this PR do?
Removes hard dependency of DI on Tracing.
Motivation:
DI code tracker must be loaded early in application boot process. Tracing must be loaded late to instrument third-party libraries. Currently, DI requires some tracing components which may result in tracing not loading correctly.
Change log entry
None - I am currently not aware of specific issues with DI or tracing loading.
Additional Notes:
I intend to add a test in a separate PR that loads DI code tracking in a forked process, verifies that the code tracking works correctly, and asserts that none of the other components (most importantly tracing but we could check others too) have been loaded.
How to test the change?
I tested the encapsulation manually by removing a bunch of requires pertaining to tracing from spec_helper.rb and other helpers. The main test of the DI code tracker both working correctly and not loading tracing will be in a later PR.