Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust matcher for template change log section #4219

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

Strech
Copy link
Member

@Strech Strech commented Dec 11, 2024

What does this PR do?

Adjusting regex to match different variants of the answers.

Motivation:

Based on observations since the initial release, it would be cool to adjust the matcher a bit. Now it will allow to write answers like: No - reason and some other.

Change log entry

No

Additional Notes:

How to test the change?
Open PR from the branch to see it in action

@Strech Strech requested a review from a team as a code owner December 11, 2024 11:28
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Dec 11, 2024
@Strech Strech added the dev/internal Other internal work that does not need to be included in the changelog label Dec 11, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks

Benchmark execution time: 2024-12-11 11:50:21

Comparing candidate commit d2d127e in PR branch fix-change-log-matcher with baseline commit b985e32 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.438op/s; -0.425op/s] or [-6.760%; -6.546%]

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 11, 2024

Datadog Report

Branch report: fix-change-log-matcher
Commit report: d2d127e
Test service: dd-trace-rb

✅ 0 Failed, 22073 Passed, 1457 Skipped, 6m 5.52s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (b985e32) to head (d2d127e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4219      +/-   ##
==========================================
+ Coverage   97.75%   97.76%   +0.01%     
==========================================
  Files        1357     1357              
  Lines       82130    82131       +1     
  Branches     4174     4174              
==========================================
+ Hits        80288    80299      +11     
+ Misses       1842     1832      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Strech Strech merged commit 1be0c46 into master Dec 11, 2024
344 of 345 checks passed
@Strech Strech deleted the fix-change-log-matcher branch December 11, 2024 14:40
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants