Fix appsec:ruleset:update rake task #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4205 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 1357 1357
Lines 81973 81974 +1
Branches 4168 4168
=======================================
+ Hits 80145 80147 +2
+ Misses 1828 1827 -1 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-12-09 13:04:13 Comparing candidate commit 39bc695 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes error handling in
appsec:ruleset:updaterake task.Motivation:
Exception when fetching the ruleset with invalid github access token.
Change log entry
None
Additional Notes:
None
How to test the change?
Run the task:
GITHUB_TOKEN=... bundle exec rake appsec:ruleset:update[1.13.3]