Removing dev and check groups from appraisal groups #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for updating Change log entry section 👏 Visited at: 2024-12-06 12:24:55 UTC |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
TonyCTHsu
changed the title
TonyCTHsu
force-pushed
the
tonycthsu/downsize-gemfiles
branch
from
c22b226 to
9ac915d
Compare
TonyCTHsu
force-pushed
the
tonycthsu/downsize-gemfiles
branch
from
2b505ef to
eea3232
Compare
BenchmarksBenchmark execution time: 2024-12-06 12:52:23 Comparing candidate commit eea3232 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
TonyCTHsu
changed the title
TonyCTHsu
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4198 +/- ##
==========================================
- Coverage 97.77% 97.75% -0.02%
==========================================
Files 1357 1357
Lines 81941 81940 -1
Branches 4168 4168
==========================================
- Hits 80114 80104 -10
- Misses 1827 1836 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I found
ruby_memcheckis propagated in Ruby 3.4, because removal list is hardcoded.This means it can easily be forgotten by people due to forgetting them.
What does this PR do?
Exclude all gems from
devandcheckgroups. Since gemfile generation is a standalone process, we can even migrateappraisalgem intodevgroup.Maybe this (customize solution )would be a better strategy compared to standalone task with its own dependency from this PR #3918
Change log entry
None.