Fix change log action condition to write warning #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dev/github
Strech
added
the
dev/internal
TonyCTHsu
approved these changes
Dec 5, 2024
Datadog ReportBranch report: ✅ 0 Failed, 21500 Passed, 1458 Skipped, 3m 15.94s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix condition (leftover after small refactoring) on when to write "Thank you" message on correct "Change log entry"
Motivation:
I've noticed that in this PR #4193 after a failed membership check action wasn't writing "Thank you" message when should. It turn out I have some leftovers in condition when to write a warning message.
Change log entry
No.
Additional Notes:
Good news - it works, bad news - it's impolite 🥸
How to test the change?
Make your profile private, open PR with no "Change log entry", correct it and don't receive any "Thank you"