Add branch test coverage report #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
added
dev/testing
|
Nice! |
marcotc
force-pushed
the
branch-coverage
branch
from
a441389 to
d897433
Compare
marcotc
force-pushed
the
branch-coverage
branch
from
d897433 to
4853330
Compare
ivoanjo
previously approved these changes
Mar 29, 2021
Gemfile
Outdated
| # Merging branch coverage results does not work for old, unsupported rubies. | ||
| # We have a fix up for review, https://github.com/simplecov-ruby/simplecov/pull/972, | ||
| # but given it only affects unsupported version of Ruby, it might not get merged. | ||
| gem 'simplecov', git: 'https://github.com/marcotc/simplecov', ref: '3bb6b7ee58bf4b1954ca205f50dd44d6f41c57db' |
There was a problem hiding this comment.
Since this may stick for a few years (it sounds like there'll be a manned mission to Mars before we drop 2.4), I suggest forking this to the datadog account, and pushing the branch there as well, just in case :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds branch coverage reporting to our CI.
Currently, our SimpleCov HTML reports will report both line and branch coverage, while the Ruby Codecov gem does not consume branch coverage data in the latest version.
There's currently an open issue with SimpleCov that happens when merging results from old rubies with new ones. I've created a PR to address it, currently awaiting feedback: simplecov-ruby/simplecov#972
I'm pointing to a GitHub commit representing that PR's changes in order to make our
coverageCI step pass.For Codecov reporting, we are waiting on support for branch coverage reporting, which was reported here: codecov/codecov-ruby#73. Meanwhile, we can see the results in the "Artifacts" tabs of the "coverage" step in CircleCI: https://123359-66497320-gh.circle-artifacts.com/0/coverage/index.html#_AllFiles