Fix Core::Telemetry stacktrace and error logging

DataDog · Dec 11, 2024 · 66aec5f · 66aec5f
1 parent b6fe8c0
commit 66aec5f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/datadog/core/telemetry/logging.rb b/lib/datadog/core/telemetry/logging.rb
@@ -41,15 +41,15 @@ def self.from(exception)
               else
                 'REDACTED'
               end
-            end.join(',')
+            end.join("\n")
           end
         end
 
         def report(exception, level: :error, description: nil)
           # Annoymous exceptions to be logged as <Class:0x00007f8b1c0b3b40>
           message = +''
           message << (exception.class.name || exception.class.inspect)
-          message << ':' << description if description
+          message << ': ' << description if description
 
           event = Event::Log.new(
             message: message,

diff --git a/spec/datadog/core/telemetry/logging_spec.rb b/spec/datadog/core/telemetry/logging_spec.rb
@@ -24,7 +24,7 @@ def log!(_event)
           )
           expect(event.payload).to include(
             logs: [{ message: 'RuntimeError', level: 'ERROR',
-                     stack_trace: a_string_including(',/spec/') }]
+                     stack_trace: a_string_including("\n/spec/") }]
           )
         end
 
@@ -39,12 +39,12 @@ def log!(_event)
         it 'sends a log event to via telemetry' do
           expect(component).to receive(:log!).with(instance_of(Datadog::Core::Telemetry::Event::Log)) do |event|
             expect(event.payload).to include(
-              logs: [{ message: 'RuntimeError:Must not contain PII', level: 'ERROR',
+              logs: [{ message: 'RuntimeError: Must not contain PII', level: 'ERROR',
                        stack_trace: a_string_including('REDACTED') }]
             )
             expect(event.payload).to include(
-              logs: [{ message: 'RuntimeError:Must not contain PII', level: 'ERROR',
-                       stack_trace: a_string_including(',/spec/') }]
+              logs: [{ message: 'RuntimeError: Must not contain PII', level: 'ERROR',
+                       stack_trace: a_string_including("\n/spec/") }]
             )
           end
 
@@ -66,7 +66,7 @@ def log!(_event)
           )
           expect(event.payload).to include(
             logs: [{ message: /#<Class:/, level: 'ERROR',
-                     stack_trace: a_string_including(',/spec/') }]
+                     stack_trace: a_string_including("\n/spec/") }]
           )
         end