Avoid starting the agent if the api key is too short #3546
Merged
+44
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
force-pushed
the
massi/api-key-check
branch
from
91b2dc8 to
7ac3e7e
Compare
masci
force-pushed
the
massi/api-key-check
branch
from
7ac3e7e to
0f84f6a
Compare
masci
force-pushed
the
massi/api-key-check
branch
from
3485321 to
e117fef
Compare
|
Note: the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Performs a sanity check before starting the agent to avoid collecting anything if the api key is obviously wrong.
Enhance the message on the status page when an api key is invalid
Motivation
The agent might start collecting metrics but never flush if users paste a wrong api key