Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): Remove none extracted value by regex #870

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Nov 22, 2024

What does this PR do?

Fix an issue when the multiline regex extract None.

Motivation

This None value lead to an error further in the logs process.

Testing Guidelines

I've set up a lambda with the DD_MULTILINE_LOG_REGEX_PATTERN: (Build:\s)|(Process:\s)|(Timestamp) and send some tricky formatted log to reproduce and fix.

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Nov 22, 2024
@ViBiOh ViBiOh merged commit 1109a8b into master Nov 22, 2024
13 checks passed
@ViBiOh ViBiOh deleted the vibioh/fix_multiregex_none branch November 22, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants