Improve release scripts #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViBiOh
force-pushed
the
vibioh/revamp_release_script
branch
from
07e34b9 to
2f5071c
Compare
ViBiOh
commented
Jul 24, 2024
| --zip-file "fileb://$layer_path" \ | ||
| --region "${region}" \ | ||
| --compatible-runtimes "${aws_version_key}" \ | ||
| --cli-read-timeout 60 | |
There was a problem hiding this comment.
Actual timeout change
Signed-off-by: Vincent Boutour <[email protected]>
ViBiOh
force-pushed
the
vibioh/revamp_release_script
branch
from
f4c5dc4 to
a38ca86
Compare
Signed-off-by: Vincent Boutour <[email protected]>
klivan
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
first publish all of the versions before creating a new release on GitHub. That way we won’t see new version on github before it’s released and we can publish it only once it’s fully deployed.
see if we can set a lower timeouts on connecting to lambda - not sure what current defaults are but it’s taking too long.
Motivation
Quicker feedback when doing a release.
Testing Guidelines
Additional Notes
Types of changes
Check all that apply