Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional access logs target bucket Resolves #764 #779

Merged
merged 2 commits into from
May 30, 2024

Conversation

xnick123
Copy link
Contributor

@xnick123 xnick123 commented Apr 25, 2024

What does this PR do?

Allows user to configure an access-logs target bucket, were access-logs of the forwarder bucket will be stored. This helps resolving AWS Security HUB S3.9 finding (more info in the issue related)

Motivation

Allow users to decide if they want a target access log bucket.

Testing Guidelines

Deployed the cloudformation template.yml with the addition made.

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@xnick123 xnick123 requested a review from a team as a code owner April 25, 2024 20:47
@xnick123
Copy link
Contributor Author

@ViBiOh Thanks for testing! Yes it was conflicting with my previous contribution. Merge conflict resolved, ping me if anything else is needed.

@ViBiOh ViBiOh merged commit 7f551c3 into DataDog:master May 30, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants