Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Add support for Python 3.11, arm64 for RDS/VPC lambda #731

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

RaphaelAllier
Copy link
Member

What does this PR do?

Updates the Cloudformation SAM templates to support Python 3.11 and arm64 for the RDS and VPC lambdas.
Because there's a change in support architecture (from x86_64 to arm) and in runtime, it is advised to perform the update manually in 2 steps (AWS will throw an error otherwise)

  • Update the runtime
  • Update the architecture.
    No code change otherwise

New installations from the Marketplace of applications or Cloudformation should work out of the box.

Tested all changes in our sandbox account.

@github-actions github-actions bot added the aws label Jan 30, 2024
@ViBiOh ViBiOh self-assigned this Jan 30, 2024
Copy link
Contributor

@ViBiOh ViBiOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration is not put in the same order if both files, but not a blocker

"{key}:{value}".format(
key=sanitize_aws_tag_string(k, remove_colons=True),
value=sanitize_aws_tag_string(v, remove_leading_digits=False),
(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by to fix a linting issue

@RaphaelAllier RaphaelAllier merged commit b1756ca into master Jan 30, 2024
13 checks passed
@RaphaelAllier RaphaelAllier deleted the raphael.allier/Py3.11RDS branch January 30, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants