approval testing #715
Merged
approval testing #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrcho
force-pushed
the
michel.daviot/approvals
branch
3 times, most recently
from
01eb7b6 to
c1e40f6
Compare
tyrcho
force-pushed
the
michel.daviot/approvals
branch
from
c1e40f6 to
bd43187
Compare
tyrcho
commented
Dec 1, 2023
| metadata, | ||
| ) | ||
| verify_as_json(list(awslogs_handler(event, context, metadata))) | ||
| verify_as_json(metadata, options=NamerFactory.with_parameters("metadata")) |
There was a problem hiding this comment.
@ge0Aja that's a useful pattern when we really want to approve 2 different things in the same test. Ideally there would be only one verify/assert but this is acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to run the tests