feat: Remove requests and all its dependencies. #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purple4reina
force-pushed
the
rey.abolofia/rm-requests
branch
from
7132262 to
cceb6de
Compare
purple4reina
force-pushed
the
rey.abolofia/rm-requests
branch
from
cceb6de to
5182136
Compare
10 mb!!!
|
purple4reina
force-pushed
the
rey.abolofia/rm-requests
branch
from
9164bda to
ef66ae7
Compare
purple4reina
force-pushed
the
rey.abolofia/rm-requests
branch
from
2aba4b7 to
e7fd46c
Compare
purple4reina
force-pushed
the
rey.abolofia/rm-requests
branch
from
e7fd46c to
b1f0490
Compare
purple4reina
force-pushed
the
rey.abolofia/rm-requests
branch
from
e518fe9 to
6ef0058
Compare
purple4reina
force-pushed
the
rey.abolofia/rm-requests
branch
from
6ef0058 to
c719f58
Compare
| @@ -25,7 +25,7 @@ classifiers = [ | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.8.0,<4" | |||
| datadog = ">=0.41.0,<1.0.0" | |||
| datadog = ">=0.51.0,<1.0.0" | |||
There was a problem hiding this comment.
don't we also need to run a poetry update to refresh the poetry lock file?
duncanista
reviewed
Jan 28, 2025
Comment on lines
+25
to
+37
| - { Ref: PythonRequirementsLambdaLayer } | ||
|
|
||
| plugins: | ||
| - serverless-python-requirements | ||
|
|
||
| custom: | ||
| pythonRequirements: | ||
| pythonBin: python3 | ||
| pipCmdExtraArgs: | ||
| - --no-deps # install just requests | ||
| layer: | ||
| compatibleRuntimes: | ||
| - ${env:SERVERLESS_RUNTIME} |
There was a problem hiding this comment.
Why do we need to add new requirements? Could you give me a brief explanation so I understand it?
There was a problem hiding this comment.
We removed requests from the lambda layer, yet the tests still rely on it. So we must add requests back.
There was a problem hiding this comment.
Thanks! I imagine these are the ones that ping URLs?
duncanista
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Requires DataDog/datadogpy#879 to be merged and released.
Removes requests and all of its dependencies from being packaged with the layer.
Motivation
v0.51.0 of the
datadogpackage will no longer require requests, instead falling back to urllib3 when present.Testing Guidelines
See testing notes in DataDog/datadogpy#879
Additional Notes
Types of Changes
Check all that apply