fix: ECS_FARGATE activating when anything is placed in the value. Ins… #31102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead only on true.
|
|
github-actions
bot
added
community
team/container-platform
clamoriniere
added
team/containers
and removed
team/container-platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tead only on true.
What does this PR do?
Addresses the issue in: #31101
Motivation
Ran into an issue where putting anything, including
false, in the variable ofECS_FARGATEresults into it is a ecs fargate agent... That's not what this should be.Describe how to test/QA your changes
Run without the environment variable
ECS_FARGATE= No Fargate.Run with the environment variable
ECS_FARGATEempty = No Fargate.Run with the environment variable
ECS_FARGATE"true" = Fargate.Run with the environment variable
ECS_FARGATE"false" = No Fargate.Run with the environment variable
ECS_FARGATE"foo" = No Fargate.Possible Drawbacks / Trade-offs
This may be a breaking change, due to anyone that was using the
ECS_FARGATEmay still work, that is only if they put the stringtrue. Otherwise, it may shutdown a lot of FARGATE services due to the change.Additional Notes
None.