-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s3 head object function. #5020
base: master
Are you sure you want to change the base?
Conversation
@DailyDreaming The right way to get a global boto3 session is not bound out; we only have module-level client and resource getters. So right now you can either hold your own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in general, but it needs a docstring and I think we need to quiet down some warnings it adds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me now.
We use this functionality already, this just centralizes it into its own function in an s3 lib.
TODO: What is the "Right Way" to invoke boto3 sessions with proper credential caching?
Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist