Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-229: workflow costs should format as currency #5233

Merged
merged 1 commit into from
Jan 24, 2025
Merged

CORE-229: workflow costs should format as currency #5233

merged 1 commit into from
Jan 24, 2025

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Jan 24, 2025 •
edited
Loading

Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-229

Summary of changes:

Workflow run costs should format as USD.

See also #5221, which may have introduced a formatting issue.

Testing strategy

  • Tested while running locally

Visual Aids

Current dev branch:
Screenshot 24-01-2025 at 15 51

This PR:
Screenshot 24-01-2025 at 15 50

@davidangb davidangb requested a review from lucymcnatt January 24, 2025 20:52
lucymcnatt
lucymcnatt approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@lucymcnatt lucymcnatt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
LGTM even with n/a values
image

@davidangb davidangb requested review from a team, kevinpalis and samanehsan and removed request for a team January 24, 2025 21:00
@davidangb davidangb added this pull request to the merge queue Jan 24, 2025
Merged via the queue into dev with commit 9542603 Jan 24, 2025
11 checks passed
@davidangb davidangb deleted the da_CORE-229_workflowCostFormatting branch January 24, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucymcnatt lucymcnatt lucymcnatt approved these changes

@kevinmarete kevinmarete kevinmarete approved these changes

@kevinpalis kevinpalis kevinpalis approved these changes

@samanehsan samanehsan Awaiting requested review from samanehsan samanehsan was automatically assigned from DataBiosphere/broad-core-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidangb @kevinpalis @kevinmarete @lucymcnatt @broadbot