AN-301 Update certifi #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizBaldo
approved these changes
Dec 9, 2024
| @@ -19,7 +19,7 @@ run_secret_setup: &run_secret_setup | |||
| command: | | |||
| git clone https://github.com/awslabs/git-secrets.git | |||
| pushd git-secrets >/dev/null | |||
| git checkout ad82d68ee924906a0401dfd48de5057731a9bc84 | |||
| git checkout 5357e18bc27b42a827b6780564ea873a72ca1f01 | |||
There was a problem hiding this comment.
Could you add a comment explaining what pointing to this specific commit does?
aednichols
approved these changes
Dec 9, 2024
.circleci/config.yml
Outdated
| @@ -28,7 +28,7 @@ jobs: | |||
| <<: *job_defaults | |||
| machine: | |||
| # latest pinned 20.04 version https://circleci.com/developer/machine/image/ubuntu-2004 | |||
| image: ubuntu-2004:202201-02 | |||
| image: ubuntu-2004:2024.11.1 | |||
There was a problem hiding this comment.
Could be worth updating to the latest LTS.
20.04 maintenance ends in April 2025.
Suggested change
| image: ubuntu-2004:2024.11.1 | |
| image: ubuntu-2404:2024.11.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.