-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-454: Add GAR specific build action #1747
Draft
rushtong
wants to merge
14
commits into
develop
Choose a base branch
from
gr-DT-454-artifact-registry
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jade-data-repo-ui Run #4021
Run Properties:
|
Project |
jade-data-repo-ui
|
Branch Review |
gr-DT-454-artifact-registry
|
Run status |
Passed #4021
|
Run duration | 03m 06s |
Commit |
e59bb7f1aa ℹ️: Merge 78d3abc6e3630629d6482acb9c918941b942a850 into f04b7f0be34d214499a60c11c7bd...
|
Committer | Gregory Rushton |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
17
|
View all changes introduced in this branch ↗︎ |
fboulnois
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early feedback:
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-454
Summary
We take inspiration from the existing build job and from an existing Terra build process. We have an existing Trivy action, so that is not included in this PR. We pull in the Terra bumper action which handles versioning. This will supercede/replace the existing TDR
helm_tag_bump
functionality.Images can be accessed via a suitable
firecloud.org
account:Future work
When this is complete and pushing images to GAR, we will need to: