Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asus: Remove System.Management #335

Merged
merged 7 commits into from
Oct 20, 2024
Merged

Asus: Remove System.Management #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cb5962
remove System.Management dependency
Aytackydln Jun 14, 2023
cadf966
Merge branch 'Development' of https://github.com/DarthAffe/RGB.NET in…
Aytackydln Aug 7, 2023
c11965e
Merge branch 'Development' of https://github.com/DarthAffe/RGB.NET in…
Aytackydln Dec 6, 2023
1bd5b54
pull
Aytackydln Dec 6, 2023
8b1c592
Merge branch 'Development' of https://github.com/DarthAffe/RGB.NET in…
Aytackydln Jan 1, 2024
5e895f5
Merge remote-tracking branch 'refs/remotes/origin/Development' into a…
Jul 2, 2024
54c09a1
Fixed default name for Asus Keyboards
DarthAffe Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RGB.NET.Devices.Asus/AsusDeviceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ protected override IEnumerable<IRGBDevice> LoadDevices()

yield return (AsusDeviceType)device.Type switch
{
AsusDeviceType.MB_RGB => new AsusMainboardRGBDevice(new AsusRGBDeviceInfo(RGBDeviceType.Mainboard, device, WMIHelper.GetMainboardInfo()?.model ?? device.Name), GetUpdateTrigger()),
AsusDeviceType.MB_RGB => new AsusMainboardRGBDevice(new AsusRGBDeviceInfo(RGBDeviceType.Mainboard, device, "Asus Motherboard"), GetUpdateTrigger()),
AsusDeviceType.MB_ADDRESABLE => new AsusUnspecifiedRGBDevice(new AsusRGBDeviceInfo(RGBDeviceType.LedStripe, device), LedId.LedStripe1, GetUpdateTrigger()),
AsusDeviceType.VGA_RGB => new AsusGraphicsCardRGBDevice(new AsusRGBDeviceInfo(RGBDeviceType.GraphicsCard, device), GetUpdateTrigger()),
AsusDeviceType.HEADSET_RGB => new AsusHeadsetRGBDevice(new AsusRGBDeviceInfo(RGBDeviceType.Headset, device), GetUpdateTrigger()),
Expand Down
82 changes: 0 additions & 82 deletions RGB.NET.Devices.Asus/Helper/WMIHelper.cs
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions RGB.NET.Devices.Asus/Keyboard/AsusKeyboardRGBDeviceInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ public sealed class AsusKeyboardRGBDeviceInfo : AsusRGBDeviceInfo, IKeyboardDevi

/// <summary>
/// The ASUS SDK returns useless names for notebook keyboards, possibly for others as well.
/// Keep a list of those and rely on <see cref="WMIHelper.GetSystemModelInfo()"/> to get the real model
/// </summary>
private static readonly List<string> GENERIC_DEVICE_NAMES = ["NotebookKeyboard"];

Expand All @@ -37,7 +36,7 @@ internal AsusKeyboardRGBDeviceInfo(IAuraSyncDevice device)

#region Methods

private static string? GetKeyboardModel(string deviceName) => GENERIC_DEVICE_NAMES.Contains(deviceName) ? WMIHelper.GetSystemModelInfo() : deviceName;
private static string? GetKeyboardModel(string deviceName) => GENERIC_DEVICE_NAMES.Contains(deviceName) ? "Asus Keyboard" : deviceName;

#endregion
}
4 changes: 0 additions & 4 deletions RGB.NET.Devices.Asus/RGB.NET.Devices.Asus.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@
<None Include="README.md" Pack="true" PackagePath="\" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="System.Management" Version="7.0.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\RGB.NET.Core\RGB.NET.Core.csproj" />
</ItemGroup>
Expand Down
Loading