estimate gnosis safe message with all gas left in the block #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahZoltu
approved these changes
Dec 11, 2024
| const [firstBlocksTransactions, ...restofTheBlocks] = transactionsWithRemoveZeroPricedOnes | ||
| if (firstBlocksTransactions === undefined) throw new Error('No blocks specified for simulateTransactionsAndSignatures') | ||
|
|
||
| // add stateOverrides only to the first block (ecrecover overrides, make me rich and such) |
There was a problem hiding this comment.
State overrides carry over to subsequent blocks?
There was a problem hiding this comment.
yeah, they modify state and state stays modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will now make eth_simulateV1 call with two blocks where the second block will contain all the calls not part of the simulation stack.
This fixes the gnosis safe issue partly but not completely (still the proxy call trickery is needed