Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show "No access" message for user-denied sites #1223

Merged
merged 1 commit into from
Dec 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/ts/components/pages/WebsiteAccess.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,9 @@ const NoAccessPrompt = ({ websiteAccess }: { websiteAccess: Signal<WebsiteAccess
const { selectedDomain } = useWebsiteAccess()
const website = useComputed(() => websiteAccess.value.website)

// If the website has been granted access, don't show this message
if (websiteAccess.value.access === true) return <></>

const confirmOrRejectRemoval = async (returnValue: string) => {
if (returnValue !== 'confirm' || !websiteAccess.value) return
await sendPopupMessageToBackgroundPage({ method: 'popup_removeWebsiteAccess', data: { websiteOrigin: websiteAccess.value.website.websiteOrigin } })
Expand Down