clean up & fix issue with form submit returning old value #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KillariDev
commented
Dec 9, 2024
KillariDev
commented
- Replace form logic which simple state change as form submit did not work (it seems to return old value and lag behind one selection)
- clean up with optional signal
|
Added a supplementary fix for this PR where all websites shows (falsely) being denied access to Interceptor @KillariDev |
Only show "No access" message for user-denied sites
MicahZoltu
approved these changes
Dec 10, 2024
|
|
||
| const requestBlockMode = useComputed(() => websiteAccess.value?.declarativeNetRequestBlockMode) | ||
| const requestBlockMode = useComputed(() => websiteAccess.value.declarativeNetRequestBlockMode) | ||
| const website = useComputed(() => websiteAccess.value.website) |
There was a problem hiding this comment.
Should this be useOptionalComputed? There are a few other places in this PR where you introduced useComputed but maybe you meant to do useOptionalComputed.
There was a problem hiding this comment.
websiteAccess is always non-undefined already in those cases so its always available (because it has been optional before where I check the undefined part). No need to have optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.