when removing address, remove it only for that chain id #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubalm
approved these changes
Nov 28, 2024
Comment on lines
+86
to
+89
| await updateUserAddressBookEntries((previousContacts) => previousContacts.filter((contact) => | ||
| !(contact.address === removeAddressBookEntry.data.address | ||
| && (contact.chainId === removeAddressBookEntry.data.chainId || (contact.chainId === undefined && removeAddressBookEntry.data.chainId === 1n)))) | ||
| ) |
There was a problem hiding this comment.
while code works perfectly fine, it may be more readable with the conditions broken down a bit
Suggested change
| await updateUserAddressBookEntries((previousContacts) => previousContacts.filter((contact) => | |
| !(contact.address === removeAddressBookEntry.data.address | |
| && (contact.chainId === removeAddressBookEntry.data.chainId || (contact.chainId === undefined && removeAddressBookEntry.data.chainId === 1n)))) | |
| ) | |
| await updateUserAddressBookEntries((previousContacts) => { | |
| const shouldKeepContact = (contact: typeof previousContacts[number]) => { | |
| const isNotTheAddressToRemove = contact.address !== removeAddressBookEntry.data.address | |
| const isNotWithinTheSameChain = contact.chainId !== removeAddressBookEntry.data.chainId | |
| const isChainIdNotUniversal = !(contact.chainId === undefined && removeAddressBookEntry.data.chainId === 1n) | |
| if (isNotTheAddressToRemove) return true | |
| return isNotWithinTheSameChain && isChainIdNotUniversal | |
| } | |
| return previousContacts.filter(shouldKeepContact) | |
| }) |
There was a problem hiding this comment.
hmm I don't think this makes it cleaner as those variable names just say directly what the statement is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.