Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear trade state when user clears input/output #99

Merged
merged 1 commit into from
Feb 12, 2024
Merged

clear trade state when user clears input/output #99

merged 1 commit into from
Feb 12, 2024

Conversation

KillariDev
Copy link

No description provided.

@KillariDev KillariDev added the bug Something isn't working label Feb 12, 2024
MicahZoltu
MicahZoltu approved these changes Feb 12, 2024
View reviewed changes
Copy link

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't break anything? I expected a more complicated/challenging change would be required.

I'm assuming skipToken means "input value is 0 or empty string"?

@KillariDev KillariDev marked this pull request as ready for review February 12, 2024 08:13
@KillariDev
Copy link
Author

This doesn't break anything? I expected a more complicated/challenging change would be required.

I'm assuming skipToken means "input value is 0 or empty string"?

well, its a bug that I caused before. skipToken means that the trade query should be skipped. I thought it meant "keep the old trade results that we have and don't perform a new trade". But It means to invalidate the results instead of keeping the old ones

@KillariDev KillariDev merged commit fbf6dc8 into main Feb 12, 2024
14 checks passed
@KillariDev KillariDev deleted the query-optimization branch February 12, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicahZoltu MicahZoltu MicahZoltu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KillariDev @MicahZoltu