wallet connection #70
Conversation
KillariDev
commented
Jan 18, 2024
•
KillariDev
commented
- If wallet connection is available always use it. Except for mainnet connection to retrieve ENS names, then we are using hard coded RPC's
- If keydonix server fails or performs poorly, use other rpc server
| return useCallback( | ||
| async (listUrl: string, skipValidation?: boolean) => { | ||
| const requestId = nanoid() | ||
| dispatch(fetchTokenList.pending({ requestId, url: listUrl })) | ||
| return getTokenList( | ||
| listUrl, | ||
| (ensName: string) => resolveENSContentHash(ensName, providers[ChainId.MAINNET]), | ||
| (ensName: string) => resolveENSContentHash(ensName, RPC_PROVIDERS[ChainId.MAINNET]), |
There was a problem hiding this comment.
Can we have this use built-in only if no wallet or wallet is not mainnet? That way if you are using Uniswap on Ethereum Mainnet it will use your wallet for ENS.
There was a problem hiding this comment.
yeah we can, I just felt this PR was big enough not to add more stuff to it
| cachedProviderRouter !== undefined && | ||
| cachedProviderRouter.chainId === providerChainId && | ||
| chainId === providerChainId && | ||
| web3Provider === cachedProviderRouter.routerProvider.provider |
There was a problem hiding this comment.
Couldn't you just do the last of these 4 checks only and it would be sufficient?
| } else { | ||
| cachedProviderRouter = undefined | ||
| } | ||
| if (providerChainId !== undefined && chainId === providerChainId && web3Provider !== undefined) { |
There was a problem hiding this comment.
Last check is redundant. If providerChainId is defined then web3Provider will never be undefined. I'm a bit sad that TypeScript doesn't notice this.
| if (providerChainId !== undefined && chainId === providerChainId && web3Provider !== undefined) { | |
| if (providerChainId !== undefined && chainId === providerChainId) { |
But maybe you need the check in order for TS to properly narrow?
| @@ -113,10 +113,9 @@ export default class AppRpcProvider extends AppStaticJsonRpcProvider { | |||
| for (const { provider, performance } of this.providerEvaluations) { | |||
| performance.callCount++ | |||
| try { | |||
| return await provider.perform(method, params) | |||
| return useSend ? await provider.send(method, params as Array<any>) : await provider.perform(method, params) | |||
There was a problem hiding this comment.
Did you figure out what send vs perform means?
There was a problem hiding this comment.
send sends the arguments as raw as they are defined by caller.
with perform you can name the variables, eg:
return [ "eth_getStorageAt", [ getLowerCase(params.address), hexZeroPad(params.position, 32), params.blockTag ] ];
I don't like this idea, as its all badly typed (all those params. values are any's), but I didn't want to start to refactor it
src/state/routing/slice.ts
Outdated
There was a problem hiding this comment.
Why did all of this need to change, and in pretty significant ways. Feels like this code has little/nothing to do with RPC selection?
There was a problem hiding this comment.
because i need to tear down the API logic, that takes only text input, and I cannot convert the web3provider to text
There was a problem hiding this comment.
A lot of this logic was handled in createApi side, but I didn't figure out a way to pass the web3provider to it
I am not confident at all that this was the smallest change possible, it wasn't really my design goal either. My main intention was to get the wallet connection working for all the crucial places, so that the hard coded RPC's are not mandatory |
