Skip to content

Commit

Permalink
Tidy up comments LBM (trixi-framework#2231)
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielDoehring authored Jan 16, 2025
1 parent cd3485b commit 9893b73
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 18 deletions.
8 changes: 0 additions & 8 deletions src/equations/lattice_boltzmann_2d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,6 @@ No-slip wall boundary condition using the bounce-back approach.
return flux
end

# Pre-defined source terms should be implemented as
# function source_terms_WHATEVER(u, x, t, equations::LatticeBoltzmannEquations2D)

# Calculate 1D flux in for a single point
@inline function flux(u, orientation::Integer, equations::LatticeBoltzmannEquations2D)
if orientation == 1
Expand All @@ -248,11 +245,6 @@ end
return v_alpha .* u
end

# Calculate maximum wave speed for local Lax-Friedrichs-type dissipation
# @inline function max_abs_speed_naive(u_ll, u_rr, orientation::Integer, equations::LatticeBoltzmannEquations2D)
# λ_max =
# end

"""
flux_godunov(u_ll, u_rr, orientation,
equations::LatticeBoltzmannEquations2D)
Expand Down
8 changes: 0 additions & 8 deletions src/equations/lattice_boltzmann_3d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,6 @@ function initial_condition_constant(x, t, equations::LatticeBoltzmannEquations3D
return equilibrium_distribution(rho, v1, v2, v3, equations)
end

# Pre-defined source terms should be implemented as
# function source_terms_WHATEVER(u, x, t, equations::LatticeBoltzmannEquations3D)

# Calculate 1D flux in for a single point
@inline function flux(u, orientation::Integer, equations::LatticeBoltzmannEquations3D)
if orientation == 1 # x-direction
Expand All @@ -238,11 +235,6 @@ end
return v_alpha .* u
end

# Calculate maximum wave speed for local Lax-Friedrichs-type dissipation
# @inline function max_abs_speed_naive(u_ll, u_rr, orientation::Integer, equations::LatticeBoltzmannEquations3D)
# λ_max =
# end

"""
flux_godunov(u_ll, u_rr, orientation,
equations::LatticeBoltzmannEquations3D)
Expand Down
2 changes: 1 addition & 1 deletion src/solvers/dgsem_tree/dg_2d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1118,7 +1118,7 @@ end
# @views mul!(surface_flux_values[v, :, direction, large_element],
# mortar_l2.reverse_upper, fstar_upper[v, :])
# @views mul!(surface_flux_values[v, :, direction, large_element],
# mortar_l2.reverse_lower, fstar_lower[v, :], true, true)
# mortar_l2.reverse_lower, fstar_lower[v, :], true, true)
# end
# The code above could be replaced by the following code. However, the relative efficiency
# depends on the types of fstar_upper/fstar_lower and dg.l2mortar_reverse_upper.
Expand Down
2 changes: 1 addition & 1 deletion src/solvers/dgsem_tree/dg_2d_parabolic.jl
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ end
# @views mul!(surface_flux_values[v, :, direction, large_element],
# mortar_l2.reverse_upper, fstar_upper[v, :])
# @views mul!(surface_flux_values[v, :, direction, large_element],
# mortar_l2.reverse_lower, fstar_lower[v, :], true, true)
# mortar_l2.reverse_lower, fstar_lower[v, :], true, true)
# end
# The code above could be replaced by the following code. However, the relative efficiency
# depends on the types of fstar_upper/fstar_lower and dg.l2mortar_reverse_upper.
Expand Down

0 comments on commit 9893b73

Please sign in to comment.