Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Optional Second button and function #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CaptainJeff
Copy link

This fork lets you add an optional button next to the "Next" button. This lets you call a function on a specific button which lets the tour be more interactive

Added a secondLabelText and secondLabelFunction that lets you pass secondLabelText for the name of the button and secondLabelFunction as the function you want to call
Adding styling to the new button
Adding the documentation for secondLabelText and secondLabelFunction
Adding width sizes for buttons
@booleanbetrayal
Copy link
Contributor

Hi @CaptainJeff - This sounds like a potentially good feature, but I'll need a couple of things from you before I can look at it further. Looks like you modified one of the dynamically built amalgamations rather than the upstream source (/src/tour/tour.js). You can edit that file and then run npm install && grunt to run tests and rebuild the dist files. Also, it would be nice if you could rebase your commits, squashing them into a single commit.

Thanks and let me know if you have any questions.

@CaptainJeff
Copy link
Author

Will do man, didn't realize I should be changing that /src/tour/tour.js file. I also changed quite a bit. I added a few optional features. Some would call functions, others would just be a href, and there were some styling features. I'll re-do this and submit again. It'll probably take me a few days or a week.

@booleanbetrayal
Copy link
Contributor

Sounds good! If you have multiple independent features you'd like to get in, it'd make more sense to do individual PRs. You can always keep a private fork and cherry-pick individual commits as needed to support your project in the meantime.

@booleanbetrayal
Copy link
Contributor

Hey @CaptainJeff - Just seeing if you would like to clean up this PR (or file a new one). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants