Skip to content

Commit

Permalink
fix: doing something dirty during valentine's day
Browse files Browse the repository at this point in the history
  • Loading branch information
meucamille committed Feb 14, 2024
1 parent e248707 commit bed5bdb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/events/use-event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export function useEvent<EventType>(
useEffect(() => {

Check warning on line 12 in src/events/use-event.ts

View workflow job for this annotation

GitHub Actions / Release

React Hook useEffect has a missing dependency: 'eventName'. Either include it or remove the dependency array
if (!callback || !observable) return;

// @ts-ignore
const eventKey = observable.on(eventName, callback);

return () => {
Expand Down

0 comments on commit bed5bdb

Please sign in to comment.